lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Sep 2015 17:42:17 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Joe Stringer <joestringer@...ira.com>, netdev@...r.kernel.org, pshelar@...ira.com Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH net 3/7] openvswitch: Fix skb leak in ovs_fragment() Hello. On 09/30/2015 01:39 AM, Joe Stringer wrote: > If ovs_fragment() was unable to fragment the skb due to an L2 header > that exceeds the supported length, skbs would be leaked. Fix the bug. > > Fixes: 7f8a436 "openvswitch: Add conntrack action" > Signed-off-by: Joe Stringer <joestringer@...ira.com> > --- > net/openvswitch/actions.c | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c > index e23a61c..e1afbd1 100644 > --- a/net/openvswitch/actions.c > +++ b/net/openvswitch/actions.c [...] > @@ -728,8 +727,14 @@ static void ovs_fragment(struct vport *vport, struct sk_buff *skb, u16 mru, > WARN_ONCE(1, "Failed fragment ->%s: eth=%04x, MRU=%d, MTU=%d.", > ovs_vport_name(vport), ntohs(ethertype), mru, > vport->dev->mtu); > - kfree_skb(skb); > + goto out; > } > + > + skb = NULL; I'd just return here. > + > +out: > + if (skb) > + kfree_skb(skb); kfree_skb() checks for NULL. [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists