lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Sep 2015 08:26:23 -0700 From: santosh shilimkar <santosh.shilimkar@...cle.com> To: Daniel Lezcano <daniel.lezcano@...aro.org>, tglx@...utronix.de Cc: linux@....linux.org.uk, Santosh Shilimkar <ssantosh@...nel.org>, "moderated list:ARM/TEXAS INSTRUM..." <linux-arm-kernel@...ts.infradead.org>, "open list:ARM/TEXAS INSTRUM..." <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] clocksource/drivers/keystone: Fix bad NO_IRQ usage On 9/30/2015 3:08 AM, Daniel Lezcano wrote: > The current code assumes the 'irq_of_parse_and_map' will return NO_IRQ in case > of failure. Unfortunately, the NO_IRQ is not consistent across the different > architectures and we must not rely on it. > > NO_IRQ is equal to '-1' on ARM and 'irq_of_parse_and_map' returns '0' in case > of an error. Hence, the latter won't be detected and will lead to a crash. > > Fix this by just checking 'irq' is different from zero. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org> > --- > drivers/clocksource/timer-keystone.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Santosh Shilimkar <ssantosh@...nel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists