linux-kernel - Re: [PATCH 07/12] atm: hide 'struct zatm_t

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11194729.bUOio0ZMW4@wuerfel>
Date:	Wed, 30 Sep 2015 17:31:28 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	"Charles (Chas) Williams" <3chas3@...il.com>
Cc:	netdev@...r.kernel.org, y2038@...ts.linaro.org,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	linux-atm-general@...ts.sourceforge.net
Subject: Re: [PATCH 07/12] atm: hide 'struct zatm_t_hist'

On Wednesday 30 September 2015 11:24:35 Charles  Williams wrote:
> On Wed, 2015-09-30 at 13:26 +0200, Arnd Bergmann wrote:
> > The zatm_t_hist structure is not used anywhere in the kernel, but is
> > exported to user space. As we are trying to eliminate uses of time_t
> > in the kernel for y2038 compatibility, the current definition triggers
> > checking tools because it contains 'struct timeval'.
> > 
> > We can work around this by adding '#ifdef __KERNEL__'. I could not find
> > out what the structure is actually used for, so this is the safe choice
> > in case there is some user space tool that relies on the definition.
> > 
> > If we are sure that nothing in user space relies on the structure, we
> > can instead remove the definition completely.
> 
> It was used by the ZATM_GETHIST ioctl which is long since gone in the
> kernel driver.  You can just remove this.

Perfect, I've updated the patch accordingly, see follow-up mail

Thanks,

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/