linux-kernel - Re: [PATCH] thermal: exynos: fix register read in TMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPdVs9i9sVP84wa2wU0qVH1-o4unvaDC+O7c1za6bJUSLw@mail.gmail.com>
Date:	Fri, 2 Oct 2015 08:43:52 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Lukasz Majewski <l.majewski@...sung.com>,
	Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	Kukjin Kim <kgene@...nel.org>, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] thermal: exynos: fix register read in TMU

2015-10-01 23:12 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@...il.com>:
> On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski wrote:
>> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@...il.com>:
>> > The value of emul_con was getting overwritten if the selected soc is
>> > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
>> > register in the case of SOC_ARCH_EXYNOS5260.
>>
>> How the value is overwritten if the soc is Exynos5260? I can't see it
>> (although the "else if" is still more obvious than "if" but how does
>> the description match the code?).
> The code here is:
> if (data->soc == SOC_ARCH_EXYNOS5260)
>         emul_con = EXYNOS5260_EMUL_CON;
> if (data->soc == SOC_ARCH_EXYNOS5433)
>         emul_con = EXYNOS5433_TMU_EMUL_CON;
> else if (data->soc == SOC_ARCH_EXYNOS7)
>         emul_con = EXYNOS7_TMU_REG_EMUL_CON;
> else
>         emul_con = EXYNOS_EMUL_CON;
>
> So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes
> EXYNOS5260_EMUL_CON. But again for the else part it will become
> EXYNOS_EMUL_CON.

Indeed!

Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU")

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/