linux-kernel - Re: [PATCH 7/8] mfd: da9052: Simplify function return logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151001072044.GH3214@x1>
Date:	Thu, 1 Oct 2015 08:20:44 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org,
	Support Opensource <support.opensource@...semi.com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 7/8] mfd: da9052: Simplify function return logic

On Tue, 29 Sep 2015, Javier Martinez Canillas wrote:

> The invoked functions already return zero on success or a negative
> errno code so there is no need to open code the logic in the caller.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> ---
> 
>  drivers/mfd/da9052-i2c.c | 6 +-----
>  drivers/mfd/da9052-spi.c | 6 +-----
>  2 files changed, 2 insertions(+), 10 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/da9052-i2c.c b/drivers/mfd/da9052-i2c.c
> index 02887001e800..2697ffb08009 100644
> --- a/drivers/mfd/da9052-i2c.c
> +++ b/drivers/mfd/da9052-i2c.c
> @@ -174,11 +174,7 @@ static int da9052_i2c_probe(struct i2c_client *client,
>  		return ret;
>  	}
>  
> -	ret = da9052_device_init(da9052, id->driver_data);
> -	if (ret != 0)
> -		return ret;
> -
> -	return 0;
> +	return da9052_device_init(da9052, id->driver_data);
>  }
>  
>  static int da9052_i2c_remove(struct i2c_client *client)
> diff --git a/drivers/mfd/da9052-spi.c b/drivers/mfd/da9052-spi.c
> index b5de8a6856c0..0f5e2c2858c1 100644
> --- a/drivers/mfd/da9052-spi.c
> +++ b/drivers/mfd/da9052-spi.c
> @@ -56,11 +56,7 @@ static int da9052_spi_probe(struct spi_device *spi)
>  		return ret;
>  	}
>  
> -	ret = da9052_device_init(da9052, id->driver_data);
> -	if (ret != 0)
> -		return ret;
> -
> -	return 0;
> +	return da9052_device_init(da9052, id->driver_data);
>  }
>  
>  static int da9052_spi_remove(struct spi_device *spi)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/