linux-kernel - Re: [PATCH 2/2] net: Microchip encx24j600 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Oct 2015 15:36:18 +0800
From:	kbuild test robot <lkp@...el.com>
To:	jon@...gle.org
Cc:	kbuild-all@...org, broonie@...nel.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Jon Ringle <jringle@...dpoint.com>
Subject: Re: [PATCH 2/2] net: Microchip encx24j600 driver

Hi Jon,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: x86_64-allmodconfig (attached as .config)
reproduce:
        git checkout abb68976e3057f70babddaf71802ed126d0297bc
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:6:0,
                    from include/linux/kernel.h:13,
                    from include/linux/delay.h:10,
                    from drivers/net/ethernet/microchip/encx24j600-regmap.c:13:
   drivers/net/ethernet/microchip/encx24j600-regmap.c: In function 'regmap_encx24j600_read':
   include/linux/kern_levels.h:4:18: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t {aka long unsigned int}' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:10:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^
   include/linux/printk.h:252:9: note: in expansion of macro 'KERN_ERR'
     printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
            ^
>> drivers/net/ethernet/microchip/encx24j600-regmap.c:310:3: note: in expansion of macro 'pr_err'
      pr_err("%s: reg=%02x reg_size=%d\n", __func__, reg, reg_size);
      ^
   include/linux/kern_levels.h:4:18: warning: format '%d' expects argument of type 'int', but argument 4 has type 'size_t {aka long unsigned int}' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:10:18: note: in expansion of macro 'KERN_SOH'
    #define KERN_ERR KERN_SOH "3" /* error conditions */
                     ^
   include/linux/printk.h:252:9: note: in expansion of macro 'KERN_ERR'
     printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
            ^
   drivers/net/ethernet/microchip/encx24j600-regmap.c:318:3: note: in expansion of macro 'pr_err'
      pr_err("%s: reg=%02x val_size=%d\n", __func__, reg, val_size);
      ^

sparse warnings: (new ones prefixed by >>)

>> drivers/net/ethernet/microchip/encx24j600.c:775:5: sparse: symbol 'encx24j600_open' was not declared. Should it be static?
>> drivers/net/ethernet/microchip/encx24j600.c:796:5: sparse: symbol 'encx24j600_stop' was not declared. Should it be static?
>> drivers/net/ethernet/microchip/encx24j600.c:897:6: sparse: symbol 'encx24j600_tx_timeout' was not declared. Should it be static?
   drivers/net/ethernet/microchip/encx24j600.c:1063:9: sparse: undefined identifier 'SET_ETHTOOL_OPS'
   drivers/net/ethernet/microchip/encx24j600.c: In function 'encx24j600_spi_probe':
   drivers/net/ethernet/microchip/encx24j600.c:1063:2: error: implicit declaration of function 'SET_ETHTOOL_OPS' [-Werror=implicit-function-declaration]
     SET_ETHTOOL_OPS(ndev, &encx24j600_ethtool_ops);
     ^
   cc1: some warnings being treated as errors

Please review and possibly fold the followup patch.

vim +/pr_err +310 drivers/net/ethernet/microchip/encx24j600-regmap.c

   294		if (reg > 0xa0)
   295			return regmap_encx24j600_spi_write(context, reg, dout, len);
   296	
   297		if (len > 2)
   298			return -EINVAL;
   299	
   300		return regmap_encx24j600_sfr_write(context, reg, dout, len);
   301	}
   302	
   303	static int regmap_encx24j600_read(void *context,
   304					  const void *reg_buf, size_t reg_size,
   305					  void *val, size_t val_size)
   306	{
   307		u8 reg = *(const u8 *)reg_buf;
   308	
   309		if (reg_size != 1) {
 > 310			pr_err("%s: reg=%02x reg_size=%d\n", __func__, reg, reg_size);
   311			return -EINVAL;
   312		}
   313	
   314		if (reg > 0xa0)
   315			return regmap_encx24j600_spi_read(context, reg, val, val_size);
   316	
   317		if (val_size > 2) {
   318			pr_err("%s: reg=%02x val_size=%d\n", __func__, reg, val_size);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (50060 bytes)