| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Oct 2015 08:56:22 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Fei Wang <w.f@...wei.com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
catalin.marinas@....com, will.deacon@....com,
devicetree@...r.kernel.org, linux@....linux.org.uk,
robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
ijc+devicetree@...lion.org.uk, khilman@...aro.org,
sameo@...ux.intel.com, broonie@...nel.org, lgirdwood@...il.com,
bintian.wang@...wei.com, xuwei5@...ilicon.com,
haojian.zhuang@...aro.org, zhangfei.gao@...aro.org,
guodong.xu@...aro.org, jorge.ramirez-ortiz@...aro.org,
puck.chen@...ilicon.com, xuyiping@...ilicon.com,
kong.kongxinwei@...ilicon.com, z.liuxinliang@...ilicon.com,
william.wfei@...il.com, zhongkaihua@...wei.com
Subject: Re: [PATCH 1/8] dt-bindings: pmic: Document Hi655x pmic driver
On Wed, 30 Sep 2015, Fei Wang wrote:
> Document the new compatible for Hisilicon Hi655x pmic driver.
s/pmic/PMIC/
> Signed-off-by: Fei Wang <w.f@...wei.com>
> ---
> .../devicetree/bindings/mfd/hisilicon,hi655x.txt | 80 ++++++++++++++++++++
> 1 file changed, 80 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
> new file mode 100644
> index 0000000..17bd8ca
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt
> @@ -0,0 +1,80 @@
> +Hisilicon hi655x Power Management Integrated Circuit (PMIC)
> +
> +hi655x consists of a large and varied group of sub-devices:
> +
> +Device Supply Names Description
> +------ ------------ -----------
> +hi655x-powerkey : : Powerkey
> +hi655x-regulator-pmic : : Regulators
> +hi655x-usbvbus : : USB plug detection
> +hi655x-pmu-rtc : : RTC
> +hi655x-coul : : Coulomb
As Mark said, these all need documentation.
> +Required properties:
> +- compatible : Should be "hisilicon,hi655x-pmic-driver"
> +- reg: Base address of PMIC on hi6220 soc
> +- #interrupt-cells: Should be 2, is the local IRQ number for hi655x.
> +- interrupt-controller: hi655x has internal IRQs (has own IRQ domain).
> +- pmu_irq_gpio: should be &gpio_pmu_irq_n, is the IRQ gpio of hi655x.
Better if you tab these out, like:
- compatible : Should be "hisilicon,hi655x-pmic-driver"
- reg : Base address of PMIC on hi6220 soc
Etc ...
> +Example:
> + pmic: pmic@...00000 {
s/F/f/
> + compatible = "hisilicon,hi655x-pmic-driver";
> + reg = <0x0 0xF8000000 0x0 0x1000>;
Small a => f please.
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + pmu_irq_gpio = <&gpio_pmu_irq_n>;
This should be <name>-gpios.
No underscores please.
> + status = "ok";
Use "okay" instead.
> + ponkey:ponkey@b1{
White space issues here.
Where is the 'reg' property?
> + compatible = "hisilicon,hi655x-powerkey";
> + interrupt-parent = <&pmic>;
> + interrupts = <6 0>, <5 0>, <4 0>;
Use #defines (same goes for all below).
> + interrupt-names = "down", "up", "hold 1s";
White space in a name seems wrong to me.
> + };
> +
> + coul: coul@1 {
What is @1?
Is this label used?
> + compatible = "hisilicon,hi655x-coul";
> + interrupt-parent = <&pmic>;
> + interrupts = <24 0>, <25 0>, <26 0>, <27 0>;
> + interrupt-names = "cl_int_i", "cl_out_i", "cl_in_i", "vbat_int_i";
> + battery_product_index = <0>;
Documentation? It doesn't look like a generic propriety either, so
should be have a vendor prefix.
> + status = "ok";
"okay"
> + };
> +
> + rtc: rtc@1 {
Is this label used?
> + compatible = "hisilicon,hi655x-pmu-rtc";
> + interrupt-parent = <&pmic>;
> + interrupts = <20 0>;
> + interrupt-names = "hi655x_pmu_rtc";
> + board_id = <1>;
What's this? No IDs in DT please.
> + };
> +
> + usbvbus:usbvbus@b2{
Whitespace.
'reg'?
> + compatible = "hisilicon,hi655x-usbvbus";
> + interrupt-parent = <&pmic>;
> + interrupts = <9 0>, <8 0>;
> + interrupt-names = "connect", "disconnect";
> + };
> +
> + ldo2: regulator@a21 {
Tabbing seems wrong here.
> + compatible = "hisilicon,hi655x-regulator-pmic";
> + regulator-name = "ldo2";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <3200000>;
> + hisilicon,valid-modes-mask = <0x02>;
> + hisilicon,valid-ops-mask = <0x01d>;
> + hisilicon,initial-mode = <0x02>;
> + hisilicon,regulator-type = <0x01>;
> +
> + hisilicon,off-on-delay = <120>;
> + hisilicon,ctrl-regs = <0x029 0x02a 0x02b>;
> + hisilicon,ctrl-data = <0x1 0x1>;
> + hisilicon,vset-regs = <0x072>;
> + hisilicon,vset-data = <0 0x3>;
> + hisilicon,regulator-n-vol = <8>;
> + hisilicon,vset-table = <2500000>,<2600000>,<2700000>,<2800000>,<2900000>,<3000000>,<3100000>,<3200000>;
Whitespace.
> + hisilicon,num_consumer_supplies = <1>;
> + hisilicon,consumer-supplies = "sensor_analog";
All of these vendor properties need documenting and signing of by Mark
(the Regulator Maintainer).
> + };
> + };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists