linux-kernel - Re: [PATCH v2] fsl-ifc: fix compilation error on ARM's 42 bit VA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1694323.vYGVsqBdJK@wuerfel>
Date:	Thu, 01 Oct 2015 10:33:31 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Lijun Pan <Lijun.Pan@...escale.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fsl-ifc: fix compilation error on ARM's 42 bit VA

On Wednesday 30 September 2015 17:55:42 Lijun Pan wrote:
> Need to include sched.h to fix the following compilation error
> if FSL_IFC is enabled on ARM64 machine.

That's good, but you did not change the subject line accordingly.

> Also, sort the include files by alphabetical order.

No need to reorder the other lines, just try to fit it in as good
as possible.

> Since ./arch/arm64/include/asm/stat.h does not
> include ./arch/arm64/include/asm/compat.h,
> it will not include include/linux/sched.h
> Hence we have to manually add "#include <linux/sched.h>"
> in drivers/memory/fsl_ifc.c

Ok, good job explaining what happened.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/