| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <560CF6D9.1080403@arm.com>
Date: Thu, 01 Oct 2015 10:03:21 +0100
From: Marc Zyngier <marc.zyngier@....com>
To: Ralf Ramsauer <ralf@...ses-pyramidenbau.de>,
linux-arm-kernel@...ts.infradead.org,
Russell King <linux@....linux.org.uk>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will.deacon@....com>,
Mark Rutland <mark.rutland@....com>
CC: linux-kernel@...r.kernel.org,
Wolfgang Mauerer <wolfgang.mauerer@...-regensburg.de>
Subject: Re: [PATCH] ARM, ARM64: Un-inlined and exported symbols of is_hyp_mode_available()
and related functions
On 30/09/15 22:40, Ralf Ramsauer wrote:
> Hypervisors may be available as modules, but need to check if
> HYP mode is enabled. Functions are provided for these means, but
> are not exported to modules; in particular since __boot_cpu_mode
> is not accessible.
>
> Instead of exporting symbol __boot_cpu_mode, un-inline
> is_hyp_mode_available() and related functions. This has no negative
> impact since they are never called in hot paths.
>
> Though all modified files are licensed under GPLv2, for ARM we use
> EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL to be consistent with the
> rest of the exports in arch/arm/kernel/setup.c.
I think that's for the authors of the original code to decide.
>
> Signed-off-by: Ralf Ramsauer <ralf@...ses-pyramidenbau.de>
> Signed-off-by: Wolfgang Mauerer <wolfgang.mauerer@...-regensburg.de>
> ---
> arch/arm/include/asm/virt.h | 21 +++------------------
> arch/arm/kernel/setup.c | 29 +++++++++++++++++++++++++++++
> arch/arm64/include/asm/virt.h | 11 ++---------
> arch/arm64/kernel/setup.c | 14 ++++++++++++++
> 4 files changed, 48 insertions(+), 27 deletions(-)
>
> diff --git a/arch/arm/include/asm/virt.h b/arch/arm/include/asm/virt.h
> index 4371f45..37d970d 100644
> --- a/arch/arm/include/asm/virt.h
> +++ b/arch/arm/include/asm/virt.h
> @@ -42,15 +42,7 @@
> */
> extern int __boot_cpu_mode;
>
> -static inline void sync_boot_mode(void)
> -{
> - /*
> - * As secondaries write to __boot_cpu_mode with caches disabled, we
> - * must flush the corresponding cache entries to ensure the visibility
> - * of their writes.
> - */
> - sync_cache_r(&__boot_cpu_mode);
> -}
> +void sync_boot_mode(void);
>
> void __hyp_set_vectors(unsigned long phys_vector_base);
> unsigned long __hyp_get_vectors(void);
> @@ -63,17 +55,10 @@ unsigned long __hyp_get_vectors(void);
> void hyp_mode_check(void);
>
> /* Reports the availability of HYP mode */
> -static inline bool is_hyp_mode_available(void)
> -{
> - return ((__boot_cpu_mode & MODE_MASK) == HYP_MODE &&
> - !(__boot_cpu_mode & BOOT_CPU_MODE_MISMATCH));
> -}
> +bool is_hyp_mode_available(void);
>
> /* Check if the bootloader has booted CPUs in different modes */
> -static inline bool is_hyp_mode_mismatched(void)
> -{
> - return !!(__boot_cpu_mode & BOOT_CPU_MODE_MISMATCH);
> -}
> +bool is_hyp_mode_mismatched(void);
> #endif
>
> #endif /* __ASSEMBLY__ */
> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> index 20edd34..c2c39f1 100644
> --- a/arch/arm/kernel/setup.c
> +++ b/arch/arm/kernel/setup.c
> @@ -915,6 +915,35 @@ static void __init reserve_crashkernel(void)
> static inline void reserve_crashkernel(void) {}
> #endif /* CONFIG_KEXEC */
>
> +#ifdef CONFIG_ARM_VIRT_EXT
> +void sync_boot_mode(void)
Why is this function global? As far as I can see, it is only called from
that very same file.
> +{
> + /*
> + * As secondaries write to __boot_cpu_mode with caches disabled, we
> + * must flush the corresponding cache entries to ensure the visibility
> + * of their writes.
> + */
> + sync_cache_r(&__boot_cpu_mode);
> +}
> +#endif
> +
> +#ifndef ZIMAGE
What is the point of this #ifndef? setup.c is not part of the decompressor.
> +/* Reports the availability of HYP mode */
> +bool is_hyp_mode_available(void)
> +{
> + return ((__boot_cpu_mode & MODE_MASK) == HYP_MODE &&
> + !(__boot_cpu_mode & BOOT_CPU_MODE_MISMATCH));
> +}
> +EXPORT_SYMBOL(is_hyp_mode_available);
> +
> +/* Check if the bootloader has booted CPUs in different modes */
> +bool is_hyp_mode_mismatched(void)
> +{
> + return !!(__boot_cpu_mode & BOOT_CPU_MODE_MISMATCH);
> +}
> +EXPORT_SYMBOL(is_hyp_mode_mismatched);
> +#endif
> +
> void __init hyp_mode_check(void)
> {
> #ifdef CONFIG_ARM_VIRT_EXT
> diff --git a/arch/arm64/include/asm/virt.h b/arch/arm64/include/asm/virt.h
> index 7a5df52..48c6170 100644
> --- a/arch/arm64/include/asm/virt.h
> +++ b/arch/arm64/include/asm/virt.h
> @@ -38,17 +38,10 @@ void __hyp_set_vectors(phys_addr_t phys_vector_base);
> phys_addr_t __hyp_get_vectors(void);
>
> /* Reports the availability of HYP mode */
> -static inline bool is_hyp_mode_available(void)
> -{
> - return (__boot_cpu_mode[0] == BOOT_CPU_MODE_EL2 &&
> - __boot_cpu_mode[1] == BOOT_CPU_MODE_EL2);
> -}
> +bool is_hyp_mode_available(void);
>
> /* Check if the bootloader has booted CPUs in different modes */
> -static inline bool is_hyp_mode_mismatched(void)
> -{
> - return __boot_cpu_mode[0] != __boot_cpu_mode[1];
> -}
> +bool is_hyp_mode_mismatched(void);
>
> /* The section containing the hypervisor text */
> extern char __hyp_text_start[];
> diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> index 6bab21f..6442d70 100644
> --- a/arch/arm64/kernel/setup.c
> +++ b/arch/arm64/kernel/setup.c
> @@ -62,6 +62,7 @@
> #include <asm/traps.h>
> #include <asm/memblock.h>
> #include <asm/efi.h>
> +#include <asm/virt.h>
> #include <asm/xen/hypervisor.h>
>
> unsigned long elf_hwcap __read_mostly;
> @@ -195,6 +196,19 @@ static void __init smp_build_mpidr_hash(void)
> __flush_dcache_area(&mpidr_hash, sizeof(struct mpidr_hash));
> }
>
> +bool is_hyp_mode_available(void)
> +{
> + return (__boot_cpu_mode[0] == BOOT_CPU_MODE_EL2 &&
> + __boot_cpu_mode[1] == BOOT_CPU_MODE_EL2);
> +}
> +EXPORT_SYMBOL_GPL(is_hyp_mode_available);
> +
> +bool is_hyp_mode_mismatched(void)
> +{
> + return __boot_cpu_mode[0] != __boot_cpu_mode[1];
> +}
> +EXPORT_SYMBOL_GPL(is_hyp_mode_mismatched);
> +
> static void __init setup_processor(void)
> {
> u64 features;
>
My main question is "Why?". As it stands, this patch is pretty useless.
What good does is_hyp_mode_mismatched bring to you? All you need to know
for sure that HYP is available.
And even then. You can issue an HVC and enter the HYP stubs, but this is
a private kernel API, and we're not exporting the actually useful stuff
(__hyp_{g,s}et_vectors).
So as it stands, this looks pretty pointless. Maybe you should explain
what you have in mind, and then we can discuss what would actually be
useful.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists