linux-kernel - Re: [PATCH 1/2] regmap: Allow installing custom reg_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151001094424.GG15635@sirena.org.uk>
Date:	Thu, 1 Oct 2015 10:44:24 +0100
From:	Mark Brown <broonie@...nel.org>
To:	jon@...gle.org
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Jon Ringle <jringle@...dpoint.com>
Subject: Re: [PATCH 1/2] regmap: Allow installing custom reg_update_bits
 function

On Thu, Oct 01, 2015 at 02:33:06AM -0400, jon@...gle.org wrote:

> @@ -2509,6 +2510,10 @@ static int _regmap_update_bits(struct regmap *map, unsigned int reg,
>  	int ret;
>  	unsigned int tmp, orig;
>  
> +	if (map->reg_update_bits)
> +		return map->reg_update_bits(map->bus_context, reg, mask, val,
> +					    change, force_write);
> +
>  	ret = _regmap_read(map, reg, &orig);
>  	if (ret != 0)
>  		return ret;

This completely bypasses and therefore breaks the cache infrastructure.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)