linux-kernel - RE: [RESEND PATCH 1/1] ASoC: dwc: correct irq clear method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <00fe01d0fbf2$5a73cba0$0f5b62e0$@tangramtek.com>
Date:	Thu, 1 Oct 2015 10:39:09 +0800
From:	"yitian" <yitian.bu@...gramtek.com>
To:	"'Mark Brown'" <broonie@...nel.org>
Cc:	<alsa-devel@...a-project.org>, <wsa@...-dreams.de>,
	<linux-kernel@...r.kernel.org>, <Andrew.Jackson@....com>,
	<tiwai@...e.com>, <lgirdwood@...il.com>, <perex@...ex.cz>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [RESEND PATCH 1/1] ASoC: dwc: correct irq clear method

> From: linux-arm-kernel
> [mailto:linux-arm-kernel-bounces@...ts.infradead.org] On Behalf Of Mark
> Brown
> Sent: Thursday, October 1, 2015 2:18 AM
> To: yitian <yitian.bu@...gramtek.com>
> Cc: alsa-devel@...a-project.org; wsa@...-dreams.de;
> linux-kernel@...r.kernel.org; Andrew.Jackson@....com; tiwai@...e.com;
> lgirdwood@...il.com; perex@...ex.cz;
> linux-arm-kernel@...ts.infradead.org
> Subject: Re: [RESEND PATCH 1/1] ASoC: dwc: correct irq clear method
> 
> On Tue, Sep 29, 2015 at 10:39:00PM +0800, yitian wrote:
> > from Designware I2S datasheet, irq is cleared by reading from
> > TOR/ROR registers, rather than by writing into them.
> 
> This doesn't apply against current code, please check and resend.
Hi Mark:

Thanks for your comments.
Maybe I misunderstand your meaning. Please correct me.

I synced up to latest kernel branch, the code is the same as what this patch
was
generated.

I checked designware I2S spec "version 1.08a June 2014", it specified that
the TOR
and ROR registers are read only and reading the last bit will clear tx/rx
overrun irq.

Also I have checked this register by writing its last bit, the overrun irq
is not cleared.
But if I read the last bit, the overrun irq is cleared. That means the spec
is correct.

Can you please let me know what else I should double check? Thanks.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/