[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20151001125423.GS1944@kernel.org>
Date: Thu, 1 Oct 2015 09:54:23 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Taeung Song <treeze.taeung@...il.com>
Cc: Ingo Molnar <mingo@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
jolsa@...hat.com, namhyung@...nel.org,
Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH v1] perf report: Fix owner error when reading perf.data
Em Thu, Oct 01, 2015 at 09:26:26PM +0900, Taeung Song escreveu:
> > On Oct 1, 2015, at 6:10 PM, Ingo Molnar <mingo@...nel.org> wrote:
> > * Taeung Song <treeze.taeung@...il.com> wrote:
> >> If perf.data file is owned by some user,
> >> it can't be read even if current user is root.
> > That's intentional: to keep a malicious local user from passing a perf.data to
> > root who does 'perf report' accidentally or in the wrong directory.
> > root can copy or chown it to himself - or we could add some --really-force flag
> > for that.
> I got it.
> I didn’t know its intention.
Feel free to transform Ingo's comment in a C source code comment right
besides the code doing that check, this way when someone else thinks
this is wrong, like you did, the comment will clarify things.
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists