linux-kernel - Re: [PATCH] x86: uapi: Fix __BITS_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMzpN2iRLgfEALJcOxVJ7c65oMS-Mu3hfq8gq+HrS+GnnNQ9dQ@mail.gmail.com>
Date:	Thu, 1 Oct 2015 09:02:37 -0400
From:	Brian Gerst <brgerst@...il.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Ben Hutchings <ben@...adent.org.uk>,
	"the arch/x86 maintainers" <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] x86: uapi: Fix __BITS_PER_LONG for x32

On Thu, Oct 1, 2015 at 4:23 AM, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Ben Hutchings <ben@...adent.org.uk> wrote:
>
>> diff --git a/arch/x86/include/uapi/asm/bitsperlong.h b/arch/x86/include/uapi/asm/bitsperlong.h
>> index b0ae1c4..217909b 100644
>> --- a/arch/x86/include/uapi/asm/bitsperlong.h
>> +++ b/arch/x86/include/uapi/asm/bitsperlong.h
>> @@ -1,7 +1,7 @@
>>  #ifndef __ASM_X86_BITSPERLONG_H
>>  #define __ASM_X86_BITSPERLONG_H
>>
>> -#ifdef __x86_64__
>> +#if defined(__x86_64__) && !defined(__ILP32__)
>>  # define __BITS_PER_LONG 64
>
> Can we write this as:
>
>    #ifdef __ILP64__

Do all versions of gcc/clang define that, even if x32 isn't supported?

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/