linux-kernel - Re: [PATCH 1/2] iommu/vt-d: Split iommu_prepare_identity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201510012216.bqRzVqhq%fengguang.wu@intel.com>
Date:	Thu, 1 Oct 2015 22:47:13 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Joerg Roedel <joro@...tes.org>
Cc:	kbuild-all@...org, iommu@...ts.linux-foundation.org,
	David Woodhouse <dwmw2@...radead.org>,
	Alex Williamson <alex.williamson@...hat.com>,
	linux-kernel@...r.kernel.org, Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH 1/2] iommu/vt-d: Split iommu_prepare_identity_map

Hi Joerg,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: ia64-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 75170658f4350889e0d0d404c5bb17179797bd47
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All warnings (new ones prefixed by >>):

   drivers/iommu/intel-iommu.c: In function 'domain_prepare_identity_map':
>> drivers/iommu/intel-iommu.c:2437:6: warning: unused variable 'ret' [-Wunused-variable]
     int ret;
         ^

vim +/ret +2437 drivers/iommu/intel-iommu.c

ba395927 drivers/pci/intel-iommu.c   Keshavamurthy, Anil S 2007-10-21  2421  	/*
ba395927 drivers/pci/intel-iommu.c   Keshavamurthy, Anil S 2007-10-21  2422  	 * RMRR range might have overlap with physical memory range,
ba395927 drivers/pci/intel-iommu.c   Keshavamurthy, Anil S 2007-10-21  2423  	 * clear it first
ba395927 drivers/pci/intel-iommu.c   Keshavamurthy, Anil S 2007-10-21  2424  	 */
c5395d5c drivers/pci/intel-iommu.c   David Woodhouse       2009-06-28  2425  	dma_pte_clear_range(domain, first_vpfn, last_vpfn);
ba395927 drivers/pci/intel-iommu.c   Keshavamurthy, Anil S 2007-10-21  2426  
c5395d5c drivers/pci/intel-iommu.c   David Woodhouse       2009-06-28  2427  	return domain_pfn_mapping(domain, first_vpfn, first_vpfn,
c5395d5c drivers/pci/intel-iommu.c   David Woodhouse       2009-06-28  2428  				  last_vpfn - first_vpfn + 1,
ba395927 drivers/pci/intel-iommu.c   Keshavamurthy, Anil S 2007-10-21  2429  				  DMA_PTE_READ|DMA_PTE_WRITE);
b213203e drivers/pci/intel-iommu.c   David Woodhouse       2009-06-26  2430  }
b213203e drivers/pci/intel-iommu.c   David Woodhouse       2009-06-26  2431  
75170658 drivers/iommu/intel-iommu.c Joerg Roedel          2015-10-01  2432  static int domain_prepare_identity_map(struct device *dev,
75170658 drivers/iommu/intel-iommu.c Joerg Roedel          2015-10-01  2433  				       struct dmar_domain *domain,
b213203e drivers/pci/intel-iommu.c   David Woodhouse       2009-06-26  2434  				       unsigned long long start,
b213203e drivers/pci/intel-iommu.c   David Woodhouse       2009-06-26  2435  				       unsigned long long end)
b213203e drivers/pci/intel-iommu.c   David Woodhouse       2009-06-26  2436  {
b213203e drivers/pci/intel-iommu.c   David Woodhouse       2009-06-26 @2437  	int ret;
b213203e drivers/pci/intel-iommu.c   David Woodhouse       2009-06-26  2438  
19943b0e drivers/pci/intel-iommu.c   David Woodhouse       2009-08-04  2439  	/* For _hardware_ passthrough, don't bother. But for software
19943b0e drivers/pci/intel-iommu.c   David Woodhouse       2009-08-04  2440  	   passthrough, we do it anyway -- it may indicate a memory
19943b0e drivers/pci/intel-iommu.c   David Woodhouse       2009-08-04  2441  	   range which is reserved in E820, so which didn't get set
19943b0e drivers/pci/intel-iommu.c   David Woodhouse       2009-08-04  2442  	   up to start with in si_domain */
19943b0e drivers/pci/intel-iommu.c   David Woodhouse       2009-08-04  2443  	if (domain == si_domain && hw_pass_through) {
9f10e5bf drivers/iommu/intel-iommu.c Joerg Roedel          2015-06-12  2444  		pr_warn("Ignoring identity map for HW passthrough device %s [0x%Lx - 0x%Lx]\n",
0b9d9753 drivers/iommu/intel-iommu.c David Woodhouse       2014-03-09  2445  			dev_name(dev), start, end);

:::::: The code at line 2437 was first introduced by commit
:::::: b213203e475212a69ad6fedfb73464087e317148 intel-iommu: Create new iommu_domain_identity_map() function

:::::: TO: David Woodhouse <David.Woodhouse@...el.com>
:::::: CC: David Woodhouse <David.Woodhouse@...el.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (43732 bytes)