linux-kernel - Re: [PATCH 2/2] irqchip: sunxi-nmi: switch to of_io_request_and_map() from of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <560D5716.9000202@arm.com>
Date:	Thu, 01 Oct 2015 16:53:58 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Chen-Yu Tsai <wens@...e.org>, Thomas Gleixner <tglx@...utronix.de>,
	Jason Cooper <jason@...edaemon.net>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>
CC:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] irqchip: sunxi-nmi: switch to of_io_request_and_map()
 from of_iomap()

On 01/10/15 16:33, Chen-Yu Tsai wrote:
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>

Please, take the time to write a commit message. You've done it in your
cover letter (where it matters the least), so why avoid doing it where
it actually benefits everyone?

> ---
>  drivers/irqchip/irq-sunxi-nmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-sunxi-nmi.c b/drivers/irqchip/irq-sunxi-nmi.c
> index 57e009917d2d..4fa46d778d02 100644
> --- a/drivers/irqchip/irq-sunxi-nmi.c
> +++ b/drivers/irqchip/irq-sunxi-nmi.c
> @@ -152,7 +152,7 @@ static int __init sunxi_sc_nmi_irq_init(struct device_node *node,
>  	}
>  
>  	gc = irq_get_domain_generic_chip(domain, 0);
> -	gc->reg_base = of_iomap(node, 0);
> +	gc->reg_base = of_io_request_and_map(node, 0, of_node_full_name(node));
>  	if (!gc->reg_base) {
>  		pr_err("%s: unable to map resource\n", DRV_NAME);
>  		ret = -ENOMEM;
> 

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/