linux-kernel - Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to platform.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151001155947.GD4469@saruman.tx.rr.com>
Date:	Thu, 1 Oct 2015 10:59:47 -0500
From:	Felipe Balbi <balbi@...com>
To:	Felipe Balbi <balbi@...com>
CC:	Marek Szyprowski <m.szyprowski@...sung.com>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-samsung-soc@...r.kernel.org>,
	Robert Baldyga <r.baldyga@...sung.com>,
	John Youn <johnyoun@...opsys.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v3 4/4] usb: dwc2: refactor common low-level hw code to
 platform.c

On Thu, Oct 01, 2015 at 10:50:18AM -0500, Felipe Balbi wrote:
> On Mon, Sep 21, 2015 at 12:16:12PM +0200, Marek Szyprowski wrote:
> > DWC2 module on some platforms needs three additional hardware
> > resources: phy controller, clock and power supply. All of them must be
> > enabled/activated to properly initialize and operate. This was initially
> > handled in s3c-hsotg driver, which has been converted to 'gadget' part
> > of dwc2 driver. Unfortunately, not all of this code got moved to common
> > platform code, what resulted in accessing DWC2 registers without
> > enabling low-level hardware resources. This fails for example on Exynos
> > SoCs. This patch moves all the code for managing those resources to
> > common platform.c file and provides convenient wrappers for controlling
> > them.
> > 
> > Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> 
> I just caught several build errors which this patch. I hope you can
> send me a follow-up fix (which I can amend to $subject) otherwise
> I'll have to drop this series

attached you can find an ARM defconfig which triggers the build error.

-- 
balbi

View attachment "defconfig" of type "text/plain" (114854 bytes)

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)