linux-kernel - Re: [PATCH v3] clk: add devm_of_clk_get() and devm_of_clk_get_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151001180534.GH19319@codeaurora.org>
Date:	Thu, 1 Oct 2015 11:05:34 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Paul Osmialowski <newchief@...g.net.pl>
Cc:	Michael Turquette <mturquette@...libre.com>,
	Russell King <linux@....linux.org.uk>,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	Paul Osmialowski <pawelo@...g.net.pl>
Subject: Re: [PATCH v3] clk: add devm_of_clk_get() and
 devm_of_clk_get_by_name() functions

On 10/01, Paul Osmialowski wrote:
> From: Paul Osmialowski <pawelo@...g.net.pl>
> 
> These two functions are added to ease management of clocks obtained
> from OF device nodes.
> 
> They are particulary useful while iterating over DT subnodes using e.g.
> for_each_child_of_node(dev->of_node, child) in order do get resources
> (i.e. clocks) for subdevices defined by these DT subnodes.
> 
> For example:
> 
> some_device {
>     compatible = "something"
>     #address-cells = <1>;
>     #size-cells = <1>;
>     ranges;
> 
>     subdevice1: some_subdevice@...e_address1 {
>         reg = <0xsome_address1 0xsome_size>
>         clocks = <&some_clock1>
>     }
> 
>     subdevice2: some_subdevice@...e_address2 {
>         reg = <0xsome_address2 0xsome_size>
>         clocks = <&some_clock2>
>     }
> }
> 
> Normally, I'd have to use of_clk_get() on each subdevice node and then
> worry about proper resource release myself.
> 
> IMHO using devres infrastructure for this is far better. This patch adds
> missing functions needed to do it a better way.
> 
> Signed-off-by: Paul Osmialowski <pawelo@...g.net.pl>

It sounds like your pinctrl binding will be rewritten so that
there isn't a need for this patch. Consider this patch rejected.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/