| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJ1xhMU64Xp4LATJ_6fUc12ENQqHSTjHO-oAzUtautfCZua7=A@mail.gmail.com>
Date: Thu, 1 Oct 2015 21:19:32 +0300
From: Alexander Kapshuk <alexander.kapshuk@...il.com>
To: linux-kernel@...r.kernel.org
Cc: Greg KH <gregkh@...uxfoundation.org>
Subject: [PATCH] ver_linux: ppp.patch
The current implementation uses both 'grep' and 'awk' for text processing
here, which may be alright as a quick solution to be run on the command
line. While in a script, 'sed' or 'awk' would be a better choice. On
top of that, the current implementation expects the version number to be
found in field 3 as seen by 'awk'. Should the output format be different,
this approach would no longer be reliable.
The proposed implementation uses 'sed' as a more flexible tool to handle
varying output formats.
Tested on:
Arch Linux
Signed-off-by: Alexander Kapshuk <alexander.kapshuk@...il.com>
---
--- linux/scripts/ver_linux.orig 2015-08-30 21:34:09.000000000 +0300
+++ linux/scripts/ver_linux 2015-09-30 22:50:41.528887446 +0300
@@ -50,8 +50,12 @@
quota -V 2>&1 | grep version | awk \
'NR==1{print "quota-tools ", $NF}'
-pppd --version 2>&1| grep version | awk \
-'NR==1{print "PPP ", $3}'
+pppd --version 2>&1 |
+sed '
+ /version/!d
+ s/[^0-9\.]//g
+ s/^/PPP\t\t\t/
+'
isdnctrl 2>&1 | grep version | awk \
'NR==1{print "isdn4k-utils ", $NF}'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists