linux-kernel - Re: [PATCH v3] cris: arch-v10: kgdb: Add '__used' for static variable is_dyn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151001191502.GF4919@axis.com>
Date:	Thu, 1 Oct 2015 21:15:03 +0200
From:	Jesper Nilsson <jesper.nilsson@...s.com>
To:	Chen Gang <xili_gchen_5257@...mail.com>
Cc:	Mikael Starvik <starvik@...s.com>,
	Jesper Nilsson <jespern@...s.com>,
	Hans-Peter Nilsson <hp@...s.com>,
	linux-cris-kernel <linux-cris-kernel@...s.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] cris: arch-v10: kgdb: Add '__used' for static
 variable is_dyn_brkp

On Thu, Aug 06, 2015 at 12:34:53AM +0200, Chen Gang wrote:
> Within one C file, current gcc can optimize the global static variables
> according to the C code, but it will skip assembly code -- it will pass
> them to gas directly.
> 
> if the static variable is used between C code and assembly code in one C
> file (e.g. is_dyn_brkp in kgdb.c), it needs '__used' to let gcc know it
> should be still used, or gcc may remove it for optimization.
> 
> The related error in this case:
> 
>     LD      init/built-in.o
>   arch/cris/arch-v10/kernel/built-in.o: In function `kgdb_handle_breakpoint':
>   (.text+0x2aca): undefined reference to `is_dyn_brkp'
>   arch/cris/arch-v10/kernel/built-in.o: In function `is_static':
>   kgdb.c:(.text+0x2ada): undefined reference to `is_dyn_brkp'
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>

Added to the cris tree, thanks!

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/