linux-kernel - Re: [PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=W5t15-aJo3W_Ym-GeLDq_xyNcAFsZcUAt61CYO+vwh=g@mail.gmail.com>
Date:	Thu, 1 Oct 2015 13:50:47 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	John Youn <John.Youn@...opsys.com>
Cc:	Yunzhi Li <lyz@...k-chips.com>,
	"jwerner@...omium.org" <jwerner@...omium.org>,
	"huangtao@...k-chips.com" <huangtao@...k-chips.com>,
	"cf@...k-chips.com" <cf@...k-chips.com>,
	"hl@...k-chips.com" <hl@...k-chips.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] usb: dwc2: reset dwc2 core before dwc2_get_hwparams()

John,

On Tue, Aug 18, 2015 at 5:19 PM, John Youn <John.Youn@...opsys.com> wrote:
> Hi Yunzhi,
>
> My concern is with the delays due to calling the dwc2_core_reset
> during probe. You could factor out the assertion of the core
> soft reset from the dwc2_core_reset and just use that before
> calling dwc2_get_hwparams().
>
> You had previously addressed the lengthy probe time issue here:
> http://marc.info/?l=linux-usb&m=142357721304377
>
> This reducing delays patch looks reasonable to me and I think it
> should get merged also. I'll do some testing with it later this
> week.

Note: you can also avoid the extra reset during probe with something
like <https://chromium-review.googlesource.com/#/c/303152/>.  I'm
happy to post that up if you want, though it depends on lyz's patch.

...in Chrome OS we've also just landed lyz's patch to reduce delays.
If there's any fallout I'll report on the list.

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/