linux-kernel - RE: [PATCH] storvsc: use small sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR0301MB1654ED62794727AD7E45546EA04C0@BY2PR0301MB1654.namprd03.prod.outlook.com>
Date:	Thu, 1 Oct 2015 21:27:42 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	Olaf Hering <olaf@...fle.de>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH] storvsc: use small sg_tablesize on x86



> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@...senPartnership.com]
> Sent: Thursday, October 1, 2015 1:52 PM
> To: KY Srinivasan <kys@...rosoft.com>
> Cc: Olaf Hering <olaf@...fle.de>; Haiyang Zhang
> <haiyangz@...rosoft.com>; linux-kernel@...r.kernel.org; linux-
> scsi@...r.kernel.org
> Subject: Re: [PATCH] storvsc: use small sg_tablesize on x86
> 
> On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:
> >
> > > -----Original Message-----
> > > From: Olaf Hering [mailto:olaf@...fle.de]
> > > Sent: Tuesday, September 8, 2015 3:07 AM
> > > To: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> > > <haiyangz@...rosoft.com>; JBottomley@...n.com
> > > Cc: linux-kernel@...r.kernel.org; linux-scsi@...r.kernel.org; Olaf Hering
> > > <olaf@...fle.de>
> > > Subject: [PATCH] storvsc: use small sg_tablesize on x86
> > >
> > > Reducing the sg_tablesize allows booting of 32bit kernels in VMs, after
> > > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set
> the
> > > tablesize based on the information given by the host")
> > >
> > > [    5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 -> 0x20
> > >
> > > Signed-off-by: Olaf Hering <olaf@...fle.de>
> > Reviewed-by: K. Y. Srinivasan <kys@...rosoft.com>
> > > ---
> > >  drivers/scsi/storvsc_drv.c | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> > > index 40c43ae..36bf183 100644
> > > --- a/drivers/scsi/storvsc_drv.c
> > > +++ b/drivers/scsi/storvsc_drv.c
> > > @@ -1907,6 +1907,11 @@ static int storvsc_probe(struct hv_device
> *device,
> > >  	 * from the host.
> > >  	 */
> > >  	host->sg_tablesize = (stor_device->max_transfer_bytes >>
> > > PAGE_SHIFT);
> > > +#if defined(CONFIG_X86_32)
> > > +	dev_warn(&device->device, "adjusting sg_tablesize 0x%x -> 0x%x",
> > > +			host->sg_tablesize,
> > > MAX_MULTIPAGE_BUFFER_COUNT);
> > > +	host->sg_tablesize = MAX_MULTIPAGE_BUFFER_COUNT;
> > > +#endif
> 
> Um, this is a bit architecture specific (I know Azure is x86, but
> still).  Can you make the define check CONFIG_32BIT rather than
> CONFIG_X86_32?

Thanks, will do.

K. Y
> 
> James
> 
>