lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Oct 2015 15:25:10 -0700 From: Stephen Boyd <sboyd@...eaurora.org> To: Victorien Vedrine <victorien.vedrine@...rys.net> Cc: linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, mturquette@...libre.com, shawn.guo@...aro.org Subject: Re: [PATCH v2] clk:mxs: Fix bug on frequency divider On 08/31, Victorien Vedrine wrote: > On drivers/clk/mxs/clk-frac.c, the function clk_frac_round_rate returned a bad > result. The division before multiplication computes a wrong value ; the > calculation is inverted to fix the problem. The second issue is that the exact > rate have decimals and they are truncate. The consequence is that the function > clk_frac_set_rate (which use the result of clk_frac_round_rate) computes a > wrong value for the register (the rate generated can be closer to the desired > rate). The correction is : if there is decimal to the result, it is rounded to > the next larger integer. > On drivers/clk/mxs/clk-frac.c, the function clk_frac_recalc_rate returned > a bad result. The multiplication is made before the division to compute a > correct value. > > Signed-off-by: Victorien Vedrine <victorien.vedrine@...rys.net> > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists