linux-kernel - Re: [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1443788513.8361.333.camel@linux.intel.com>
Date:	Fri, 02 Oct 2015 15:21:53 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Lee Jones <lee@...nel.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] mfd: intel-lpss: fix build error when
 !CONFIG_PM_SLEEP

On Thu, 2015-10-01 at 15:45 +0100, Lee Jones wrote:
> On Thu, 01 Oct 2015, Andy Shevchenko wrote:
> 
> > Jim Davis reported the compilation error with a random 
> > configuration which
> > apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that 
> > conditions we have
> > missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.
> > 
> > Reported-by: Jim Davis <jim.epost@...il.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > ---
> >  drivers/mfd/intel-lpss.h | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Why are you using this email address?

In fact it *had* the proper address [1] and after you confused me [2].

[1] http://www.spinics.net/lists/kernel/msg2073973.html
[2] http://www.spinics.net/lists/linux-fsdevel/msg90269.html

> 
> Please use ./get_maintainer.pl properly.
> 
> > diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h
> > index f28cb28a..2c7f8d7 100644
> > --- a/drivers/mfd/intel-lpss.h
> > +++ b/drivers/mfd/intel-lpss.h
> > @@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev);
> >  	.thaw = intel_lpss_resume,		\
> >  	.poweroff = intel_lpss_suspend,		\
> >  	.restore = intel_lpss_resume,
> > +#else
> > +#define INTEL_LPSS_SLEEP_PM_OPS
> >  #endif
> >  
> >  #define INTEL_LPSS_RUNTIME_PM_OPS		\

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/