linux-kernel - Re: [PATCH] arm64: ftrace: fix function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 Oct 2015 13:42:41 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	AKASHI Takahiro <takahiro.akashi@...aro.org>
Cc:	zhouchengming1@...wei.com, ard.biesheuvel@...aro.org,
	dingtianhong@...wei.com, will.deacon@....com,
	linux-kernel@...r.kernel.org, rostedt@...dmis.org,
	lizefan@...wei.com, Li Bin <huawei.libin@...wei.com>,
	guohanjun@...wei.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm64: ftrace: fix function_graph tracer panic

On Fri, Oct 02, 2015 at 04:56:48PM +0900, AKASHI Takahiro wrote:
> >>On 09/30/2015 11:49 AM, Li Bin wrote:
> >>>This is because when using function graph tracer, if the traced
> >>>function return value is in multi regs ([0x-07]), return_to_handler
> 
> typo: 0x-07 => x0-x7

I fixed this up.

> and pre/post-indexed addressing stp&ldp may save add&sub instructions, but
> it's a matter of preference.

Doing it this way is more efficient in general as it avoids updating the
sp and writing in reverse order. That's the reason we recently changed
the kernel_entry/exit macros (see commit 63648dd20fa0 "arm64: entry:
use ldp/stp instead of push/pop when saving/restoring regs").

Thanks.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/