linux-kernel - Re: [PATCH] kernel/params.c: remove confusing cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87fv1unk5v.fsf@rustcorp.com.au>
Date:	Fri, 02 Oct 2015 10:47:32 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Rasmus Villemoes <linux@...musvillemoes.dk>,
	linux-kernel@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [PATCH] kernel/params.c: remove confusing cast

Rasmus Villemoes <linux@...musvillemoes.dk> writes:
> Both sides of the assignment are const char*, so this cast is
> unnecessary and confusing.
>
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Acked-by: Rusty Russell <rusty@...tcorp.com.au>

Thanks,
Rusty.

>  kernel/params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/params.c b/kernel/params.c
> index b6554aa71094..0b433fdb45eb 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -709,7 +709,7 @@ static __modinit int add_sysfs_param(struct module_kobject *mk,
>  		mk->mp->attrs[mk->mp->num].mattr.store = param_attr_store;
>  	else
>  		mk->mp->attrs[mk->mp->num].mattr.store = NULL;
> -	mk->mp->attrs[mk->mp->num].mattr.attr.name = (char *)name;
> +	mk->mp->attrs[mk->mp->num].mattr.attr.name = name;
>  	mk->mp->attrs[mk->mp->num].mattr.attr.mode = kp->perm;
>  	mk->mp->num++;
>  
> -- 
> 2.1.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/