linux-kernel - Re: [PATCH 2/3] iio: ad5064: Explicitly configure whether to use external supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Oct 2015 21:29:17 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Paul Cercueil <paul.cercueil@...log.com>
Cc:	kbuild-all@...org, Jonathan Cameron <jic23@...nel.org>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Hartmut Knaack <knaack.h@....de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	Paul Cercueil <paul.cercueil@...log.com>
Subject: Re: [PATCH 2/3] iio: ad5064: Explicitly configure whether to use
 external supply

Hi Paul,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: cris-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=cris 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/iio/dac/ad5064.c: In function 'ad5064_probe':
>> drivers/iio/dac/ad5064.c:468:3: warning: 'ext_vref' may be used uninitialized in this function [-Wuninitialized]

vim +/ext_vref +468 drivers/iio/dac/ad5064.c

   452	
   453		indio_dev = devm_iio_device_alloc(dev, sizeof(*st));
   454		if (indio_dev == NULL)
   455			return  -ENOMEM;
   456	
   457		st = iio_priv(indio_dev);
   458		dev_set_drvdata(dev, indio_dev);
   459	
   460		st->chip_info = &ad5064_chip_info_tbl[type];
   461		st->dev = dev;
   462		st->write = write;
   463	
   464		for (i = 0; i < ad5064_num_vref(st); ++i)
   465			st->vref_reg[i].supply = ad5064_vref_name(st, i);
   466	
   467		if (dev->of_node) {
 > 468			for (i = 0; ext_vref && i < ad5064_num_vref(st); ++i)
   469				ext_vref = of_property_read_bool(dev->of_node,
   470						ad5064_vref_name(st, i));
   471		} else {
   472			struct ad5064_platform_data *pdata = dev->platform_data;
   473	
   474			ext_vref = pdata && pdata->use_external_ref;
   475		}
   476	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (36364 bytes)