| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1443792901-19610-1-git-send-email-konrad.wilk@oracle.com> Date: Fri, 2 Oct 2015 09:35:01 -0400 From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> To: linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org Cc: Cathy Avery <cathy.avery@...cle.com>, Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> Subject: [PATCH] xen-blkfront: check for null drvdata in blkback_changed (XenbusStateClosing) From: Cathy Avery <cathy.avery@...cle.com> xen-blkfront will crash if the check to talk_to_blkback() in blkback_changed()(XenbusStateInitWait) returns an error. The driver data is freed and info is set to NULL. Later during the close process via talk_to_blkback's call to xenbus_dev_fatal() the null pointer is passed to and dereference in blkfront_closing. Signed-off-by: Cathy Avery <cathy.avery@...cle.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> --- drivers/block/xen-blkfront.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 0823a96..04fc7b4 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1955,7 +1955,8 @@ static void blkback_changed(struct xenbus_device *dev, break; /* Missed the backend's Closing state -- fallthrough */ case XenbusStateClosing: - blkfront_closing(info); + if (info) + blkfront_closing(info); break; } } -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists