| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Oct 2015 15:40:28 +0200 From: Javier Martinez Canillas <javier@....samsung.com> To: linux-kernel@...r.kernel.org Cc: Javier Martinez Canillas <javier@....samsung.com>, Hans de Goede <hdegoede@...hat.com>, Benjamin Tissoires <benjamin.tissoires@...hat.com>, Henrik Rydberg <rydberg@...math.org>, linux-input@...r.kernel.org, Dmitry Torokhov <dmitry.torokhov@...il.com> Subject: [PATCH 17/18] Input: cypress_ps2 - simplify function return logic The invoked function already returns zero on success or a negative errno code so there is no need to open code the logic in the caller. This also fixes the following make coccicheck warning: drivers/input/mouse/cypress_ps2.c:333:1-4: WARNING: end returns can be simplified Signed-off-by: Javier Martinez Canillas <javier@....samsung.com> --- drivers/input/mouse/cypress_ps2.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/input/mouse/cypress_ps2.c b/drivers/input/mouse/cypress_ps2.c index 28dcfc822bf6..bca984f53434 100644 --- a/drivers/input/mouse/cypress_ps2.c +++ b/drivers/input/mouse/cypress_ps2.c @@ -330,11 +330,7 @@ static int cypress_query_hardware(struct psmouse *psmouse) if (ret) return ret; - ret = cypress_read_tp_metrics(psmouse); - if (ret) - return ret; - - return 0; + return cypress_read_tp_metrics(psmouse); } static int cypress_set_absolute_mode(struct psmouse *psmouse) -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists