linux-kernel - Re: [PATCH v2 2/2] perf tools: report PERF_FLAG_FD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1443793411.3188.25.camel@opteya.com>
Date:	Fri, 02 Oct 2015 15:43:31 +0200
From:	Yann Droneaud <ydroneaud@...eya.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Adrian Hunter <adrian.hunter@...el.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	William Cohen <wcohen@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] perf tools: report PERF_FLAG_FD_CLOEXEC probing
 error once

Le vendredi 02 octobre 2015 à 15:20 +0200, Jiri Olsa a écrit :
> On Thu, Oct 01, 2015 at 05:16:26PM +0200, Yann Droneaud wrote:
> > In case of failure, unrelated to PERF_FLAG_FD_CLOEXEC,
> > perf_flag_probe() reports the error twice. For example:
> > 
> >   $ perf record ls
> >   Error:
> >   perf_event_open(..., PERF_FLAG_FD_CLOEXEC) failed with unexpected
> > error 16 (Device or resource busy)
> >   perf_event_open(..., 0) failed unexpectedly with error 16 (Device
> > or resource busy)
> 
> so this error message is no longer possible due to your earlier patch
> right?
> 

My bad, the error used to illustrate the behavior is not well choosed. 

> could you please provide current 'before&after' output into changelog
> otherwise it looks ok 
> 

OK. I'm updating the message.

Regards.

-- 
Yann Droneaud
OPTEYA


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/