linux-kernel - Re: [PATCH 06/18] Input: zforce - simplify function return logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9921230.rYIRnnZOQ1@diego>
Date:	Fri, 02 Oct 2015 15:54:51 +0200
From:	Heiko Stübner <heiko.stuebner@...com>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, Jingoo Han <jg1.han@...sung.com>,
	Dirk Behme <dirk.behme@...bosch.com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	linux-input@...r.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH 06/18] Input: zforce - simplify function return logic

Am Freitag, 2. Oktober 2015, 15:40:17 schrieb Javier Martinez Canillas:
> The invoked function already returns zero on success or a negative
> errno code so there is no need to open code the logic in the caller.
> 
> This also fixes the following make coccicheck warning:
> 
> end returns can be simplified and declaration on line 602 can be dropped
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

I wonder what let me make that decision ... probably copy'n'paste from my auo-
pixcir driver ... but how that got into this one is still a mystery to me ;-)
anyway

Reviewed-by: Heiko Stuebner <heiko.stuebner@...com>


> ---
> 
>  drivers/input/touchscreen/zforce_ts.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/zforce_ts.c
> b/drivers/input/touchscreen/zforce_ts.c index 781d0f83050a..9bbadaaf6bc3
> 100644
> --- a/drivers/input/touchscreen/zforce_ts.c
> +++ b/drivers/input/touchscreen/zforce_ts.c
> @@ -599,13 +599,8 @@ static irqreturn_t zforce_irq_thread(int irq, void
> *dev_id) static int zforce_input_open(struct input_dev *dev)
>  {
>  	struct zforce_ts *ts = input_get_drvdata(dev);
> -	int ret;
> 
> -	ret = zforce_start(ts);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return zforce_start(ts);
>  }
> 
>  static void zforce_input_close(struct input_dev *dev)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/