linux-kernel - Re: [PATCH] Input: goldfish - Allow compile the driver with COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151002175342.GF8437@dtor-ws>
Date:	Fri, 2 Oct 2015 10:53:42 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org,
	Luis de Bethencourt <luisbg@....samsung.com>,
	Hans de Goede <hdegoede@...hat.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Scott Branden <sbranden@...adcom.com>,
	Robin Gong <b38343@...escale.com>,
	Lee Jones <lee.jones@...aro.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Matt Ranostay <mranostay@...il.com>,
	linux-input@...r.kernel.org, Frank Li <Frank.Li@...escale.com>
Subject: Re: [PATCH] Input: goldfish - Allow compile the driver with
 COMPILE_TEST

On Fri, Oct 02, 2015 at 04:47:58PM +0200, Javier Martinez Canillas wrote:
> The driver depends on GOLDFISH but there isn't a build dependency
> so it's a good idea to allow the driver to be built even if that
> option is disabled, if the COMPILE_TEST option is enabled.
> 
> That way, the driver can be built with a config generated by make
> allyesconfig and can be checked if a patch would break the build.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> 

Applied, thank you.

> ---
> 
>  drivers/input/keyboard/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
> index 2e80107ff630..ddd8148d51d7 100644
> --- a/drivers/input/keyboard/Kconfig
> +++ b/drivers/input/keyboard/Kconfig
> @@ -516,7 +516,7 @@ config KEYBOARD_SAMSUNG
>  	  module will be called samsung-keypad.
>  
>  config KEYBOARD_GOLDFISH_EVENTS
> -	depends on GOLDFISH
> +	depends on GOLDFISH || COMPILE_TEST
>  	tristate "Generic Input Event device for Goldfish"
>  	help
>  	  Say Y here to get an input event device for the Goldfish virtual
> -- 
> 2.4.3
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/