linux-kernel - Re: [PATCH] ver_linux: module-init-tools.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Oct 2015 11:10:31 -0700
From:	Jim Davis <jim.epost@...il.com>
To:	Alexander Kapshuk <alexander.kapshuk@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] ver_linux: module-init-tools.patch

On Thu, Oct 1, 2015 at 11:49 AM, Alexander Kapshuk
<alexander.kapshuk@...il.com> wrote:
> The current implementation relies on 'depmod' to be available in the
> PATH. It also expects the version number to be found in the last field
> as seen by 'awk'. Should the output format be different, this approach
> would no longer be reliable.
>
> The proposed implementation locates 'depmod', and uses 'sed' as a more
> flexible tool to handle varying output formats.
>
> Tested on:
> Gentoo Linux
> Debian 6.0.10
> Oracle Linux Server release 7.1
> Arch Linux
> openSuSE 13.2
>
>
> Signed-off-by: Alexander Kapshuk <alexander.kapshuk@...il.com>
> ---
>
> --- linux/scripts/ver_linux.orig    2015-10-01 18:36:49.090519891 +0300
> +++ linux/scripts/ver_linux    2015-10-01 21:48:09.985628346 +0300
> @@ -25,7 +25,14 @@
>  echo -n "mount                  "
>  mount --version | awk '{print $NF}' | sed -e s/^mount-// -e s/\)$//
>
> -depmod -V  2>&1 | awk 'NR==1 {print "module-init-tools     ",$NF}'
> +depmod=`whereis depmod | awk '{print $2}'`

Hmm.

jim@...bstar:~$ which depmod
/usr/local/bin/depmod
jim@...bstar:~$ whereis depmod
depmod: /sbin/depmod /etc/depmod.d /usr/local/bin/depmod
/usr/share/man/man8/depmod.8.gz

So while according to my $PATH preferences I'd rather run
/usr/local/bin/depmod, it looks like the '{print $2}' thing would pick
/sbin/depmod instead.

Not a big deal, but I suspect those sort of considerations are why the
scripts tend just to check the $PATH.

-- 
Jim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/