linux-kernel - Re: [PATCH v4] clk: add CS2000 Fractional-N driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151002181123.GM12338@codeaurora.org>
Date:	Fri, 2 Oct 2015 11:11:23 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:	Simon <horms@...ge.net.au>,
	Michael Turquette <mturquette@...libre.com>,
	Magnus <magnus.damm@...il.com>,
	Linux-SH <linux-sh@...r.kernel.org>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	linux-clk@...r.kernel.org
Subject: Re: [PATCH v4] clk: add CS2000 Fractional-N driver

On 10/02, Kuninori Morimoto wrote:
> 
> Hi Stephen
> 
> Thank you for your review
> 
> > > +	init.parent_names	= parent_names;
> > > +	init.num_parents	= ARRAY_SIZE(parent_names);
> > > +
> > > +	priv->hw.init = &init;
> > > +
> > > +	clk = clk_register(NULL, &priv->hw);
> > 
> > How about using devm_clk_register() and passing the i2c device
> > down to this function?
> 
> Can I confirm ?
> Does this "i2c device down" means call i2c_set_clientdata()
> in this function ?

I mean passing a struct device pointer to this function and then
using it here in the clk_register() function.

> 
> > > +static int cs2000_clk_init(struct cs2000_priv *priv)
> > > +{
> > > +	struct device *dev = priv_to_dev(priv);
> > > +	struct device_node *np = dev->of_node;
> > > +	u32 rate;
> > > +	int ch = 0; /* it uses ch0 only at this point */
> > > +	int ret;
> > > +
> > > +	if (of_property_read_u32(np, "clock-frequency", &rate))
> > 
> > Why can't we do this with DT assigned rates?
> 
> What doesn this "DT assigned rates" mean ?
> this rate will be used as default output

See the "Assigned clock parents and rates" section of
Documentation/devicetree/bindings/clock/clock-bindings.txt and
commit 86be408bfbd8 (clk: Support for clock parents and rates
assigned from device tree, 2014-06-18).

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/