linux-kernel - Re: [PATCH 15/18] Input: auo-pixcir-ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151002181926.GL8437@dtor-ws>
Date:	Fri, 2 Oct 2015 11:19:26 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, Jingoo Han <jg1.han@...sung.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH 15/18] Input: auo-pixcir-ts - simplify function return
 logic

On Fri, Oct 02, 2015 at 03:40:26PM +0200, Javier Martinez Canillas wrote:
> The invoked function already returns zero on success or a negative
> errno code so there is no need to open code the logic in the caller.
> 
> This also fixes the following make coccicheck warnings:
> 
> end returns can be simplified and declaration on line 402 can be dropped
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Applied, thank you.

> ---
> 
>  drivers/input/touchscreen/auo-pixcir-ts.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/auo-pixcir-ts.c b/drivers/input/touchscreen/auo-pixcir-ts.c
> index 38c06f754acd..6592fc5d48b4 100644
> --- a/drivers/input/touchscreen/auo-pixcir-ts.c
> +++ b/drivers/input/touchscreen/auo-pixcir-ts.c
> @@ -399,13 +399,8 @@ static int auo_pixcir_stop(struct auo_pixcir_ts *ts)
>  static int auo_pixcir_input_open(struct input_dev *dev)
>  {
>  	struct auo_pixcir_ts *ts = input_get_drvdata(dev);
> -	int ret;
> -
> -	ret = auo_pixcir_start(ts);
> -	if (ret)
> -		return ret;
>  
> -	return 0;
> +	return auo_pixcir_start(ts);
>  }
>  
>  static void auo_pixcir_input_close(struct input_dev *dev)
> -- 
> 2.4.3
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/