linux-kernel - Re: [PATCH 02/18] Input: ads7846

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151002182144.GO8437@dtor-ws>
Date:	Fri, 2 Oct 2015 11:21:44 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	Jingoo Han <jg1.han@...sung.com>
Subject: Re: [PATCH 02/18] Input: ads7846 - use PTR_ERR_OR_ZERO()

On Fri, Oct 02, 2015 at 03:40:13PM +0200, Javier Martinez Canillas wrote:
> The PTR_ERR_OR_ZERO() helper function checks if a pointer contains an
> errno code and returns it or return 0 if that's not the case. Use the
> helper instead of open coding the same logic in the driver. This was
> found with make coccicheck that complains with the following warning:
> 
> drivers/input/touchscreen/ads7846.c:532:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Applied, thank you.

> ---
> 
>  drivers/input/touchscreen/ads7846.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
> index 0f5f968592bd..727d88c900c1 100644
> --- a/drivers/input/touchscreen/ads7846.c
> +++ b/drivers/input/touchscreen/ads7846.c
> @@ -529,10 +529,8 @@ static int ads784x_hwmon_register(struct spi_device *spi, struct ads7846 *ts)
>  
>  	ts->hwmon = hwmon_device_register_with_groups(&spi->dev, spi->modalias,
>  						      ts, ads7846_attr_groups);
> -	if (IS_ERR(ts->hwmon))
> -		return PTR_ERR(ts->hwmon);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(ts->hwmon);
>  }
>  
>  static void ads784x_hwmon_unregister(struct spi_device *spi,
> -- 
> 2.4.3
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/