linux-kernel - Re: [PATCH v1 2/3] uio_pci_generic: add MSI/MSI-X support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201510050037.OLQ2QjiG%fengguang.wu@intel.com>
Date:	Mon, 5 Oct 2015 00:58:59 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Vlad Zolotarov <vladz@...udius-systems.com>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org, mst@...hat.com,
	hjk@...sjkoch.de, regkh@...uxfoundation.org, corbet@....net,
	bruce.richardson@...el.com, avi@...udius-systems.com,
	gleb@...udius-systems.com, stephen@...workplumber.org,
	alexander.duyck@...il.com,
	Vlad Zolotarov <vladz@...udius-systems.com>
Subject: Re: [PATCH v1 2/3] uio_pci_generic: add MSI/MSI-X support

Hi Vlad,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: xtensa-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All error/warnings (new ones prefixed by >>):

   drivers/uio/uio_pci_generic.c: In function 'uio_pci_generic_ioctl':
>> drivers/uio/uio_pci_generic.c:189:3: error: implicit declaration of function 'copy_from_user' [-Werror=implicit-function-declaration]
      if (copy_from_user(&hdr, (void __user *)arg, sizeof(hdr)))
      ^
>> drivers/uio/uio_pci_generic.c:208:4: error: implicit declaration of function 'put_user' [-Werror=implicit-function-declaration]
       err = put_user(0, (u32 __user *)arg);
       ^
   cc1: some warnings being treated as errors

vim +/copy_from_user +189 drivers/uio/uio_pci_generic.c

   183		struct uio_pci_generic_dev *gdev = to_uio_pci_generic_dev(info);
   184		struct uio_pci_generic_irq_set hdr;
   185		int err;
   186	
   187		switch (cmd) {
   188		case UIO_PCI_GENERIC_IRQ_SET:
 > 189			if (copy_from_user(&hdr, (void __user *)arg, sizeof(hdr)))
   190				return -EFAULT;
   191	
   192			/* Locking is needed to ensure two things:
   193			 *  1) Two IRQ_SET ioctl()'s are not running in parallel.
   194			 *  2) IRQ_SET ioctl() is not running in parallel with remove().
   195			 */
   196			mutex_lock(&gdev->msix_state_lock);
   197			if (gdev->int_mode != UIO_INT_MODE_MSIX) {
   198				mutex_unlock(&gdev->msix_state_lock);
   199				return -EOPNOTSUPP;
   200			}
   201	
   202			err = set_irq_eventfd(gdev, hdr.vec, hdr.fd);
   203			mutex_unlock(&gdev->msix_state_lock);
   204	
   205			break;
   206		case UIO_PCI_GENERIC_IRQ_NUM_GET:
   207			if (gdev->int_mode == UIO_INT_MODE_NONE)
 > 208				err = put_user(0, (u32 __user *)arg);
   209			else if (gdev->int_mode != UIO_INT_MODE_MSIX)
   210				err = put_user(1, (u32 __user *)arg);
   211			else

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (42410 bytes)