linux-kernel - Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20151004194313.GB23542@kroah.com>
Date:	Sun, 4 Oct 2015 20:43:13 +0100
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Mike Dupuis <mike.dupuis.0@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Staging: rtl8192u: remove ieee80211_ccmp_null()


On Sun, Oct 04, 2015 at 10:46:05AM -0800, Mike Dupuis wrote:
> > And I think you just broke the "autoload" logic that these "call a null
> > function" function calls were trying to solve, which isn't good at all.
> 
> I guess this bit is lost on me-- how does calling a function from a
> previously unused object affect the state of a driver or kernel module?

It forces the module where that function is to be loaded into memory
before this function can be called.

That is if we have multiple modules here, I haven't looked at the code
in a long time to verify it, but note, you are totally ignoring the
comment put there in the code that says this.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/