linux-kernel - Re: [PATCH] staging: rdma: Fix braces around if/else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5610CB98.1090907@mellanox.com>
Date:	Sun, 4 Oct 2015 09:47:52 +0300
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Martin Kletzander <mkletzan@...hat.com>,
	<devel@...verdev.osuosl.org>,
	Mike Marciniszyn <infinipath@...el.com>,
	Doug Ledford <dledford@...hat.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	<linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rdma: Fix braces around if/else

On 10/3/2015 11:55 PM, Martin Kletzander wrote:
> Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl.

Hi Greg,

Is there a way to signal people/tools that a certain driver parks in 
staging on their way **out** of the kernel
and not the other way around? I guess you (nor Doug) don't want to spend 
time on fixing such drivers, right?

Or.

>
> Signed-off-by: Martin Kletzander <mkletzan@...hat.com>
> ---
> There is one warning reported in this patch though.  That's because of
> the multiline string and it's pre-existing.  Feel free to let me know
> if that should be fixed too, I'd also remove the pointless '#' then.
> On the other hand, it'll create more-than-80-columns long line.
>
>   drivers/staging/rdma/ipath/ipath_driver.c    | 19 ++++++++-----------
>   drivers/staging/rdma/ipath/ipath_file_ops.c  | 12 ++++++------
>   drivers/staging/rdma/ipath/ipath_iba6110.c   |  7 +++----
>   drivers/staging/rdma/ipath/ipath_init_chip.c | 10 +++++-----
>   drivers/staging/rdma/ipath/ipath_intr.c      |  7 +++----
>   drivers/staging/rdma/ipath/ipath_sysfs.c     |  7 +++----
>   drivers/staging/rdma/ipath/ipath_verbs.c     |  4 ++--
>   7 files changed, 30 insertions(+), 36 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/