linux-kernel - Re: [PATCH] staging: dgap: remove unused configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 5 Oct 2015 15:43:32 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	devel@...verdev.osuosl.org, Lidza Louina <lidza.louina@...il.com>,
	Daeseok Youn <daeseok.youn@...il.com>,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] staging: dgap: remove unused configuration

On Mon, Oct 05, 2015 at 12:46:43PM +0300, Dan Carpenter wrote:
> On Sun, Oct 04, 2015 at 09:19:20PM +0530, Sudip Mukherjee wrote:
> > The IO configuration was not used to configure the board. It was only
> > read from the configuration file. Stop reading it and also remove the
> > other related variables defined for it.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> 
> But say someone has an old config file with IO in it, doesn't this break
> their system?
No, it should not. dgap_parsefile() is executing a loop and reading
tokens from the configuration file and depending on what token it has
read it will do switch-case. And it will not find case IO: anymore and
will be just ignored (there is no default:).

And this is actually just a first step towards removing the
configuration file as Greg was telling that loading a firmware file and
consideing it as a configuartion file is not the right thing to do. So I
am removing all the unused configurations one at a time and after they
are removed then depending on the configurations left I will ask for
your suggestion how to remove the use of configuration file.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/