linux-kernel - RE: [PATCH] mm/mmap.c: Remove redundant vma looping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <COL130-W277AB820846A550742188BB9480@phx.gbl>
Date:	Mon, 5 Oct 2015 20:23:51 +0800
From:	Chen Gang <xili_gchen_5257@...mail.com>
To:	"aarcange@...hat.com" <aarcange@...hat.com>
CC:	Richard Weinberger <richard.weinberger@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
	"riel@...hat.com" <riel@...hat.com>, Michal Hocko <mhocko@...e.cz>,
	"oleg@...hat.com" <oleg@...hat.com>,
	"asha.levin@...cle.com" <asha.levin@...cle.com>,
	"pfeiner@...gle.com" <pfeiner@...gle.com>,
	"vishnu.ps@...sung.com" <vishnu.ps@...sung.com>,
	Linux Memory <linux-mm@...ck.org>,
	kernel mailing list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mm/mmap.c: Remove redundant vma looping

> From: aarcange@...hat.com
>
> Hello Chen,
>
> On Sun, Oct 04, 2015 at 12:55:29PM +0800, Chen Gang wrote:
>> Theoretically, the lock and unlock need to be symmetric, if we have to
>> lock f_mapping all firstly, then lock all anon_vma, probably, we also
>> need to unlock anon_vma all, then unlock all f_mapping.
>
> They don't need to be symmetric because the unlocking order doesn't
> matter. To avoid lock inversion deadlocks it is enough to enforce the
> lock order.

OK, thanks. I shall continue to find another patches. :-)

--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed