linux-kernel - Re: [PATCH] iwlwifi: Deinline iwl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 05 Oct 2015 15:26:14 +0300
From:	Luca Coelho <luca@...lho.fi>
To:	Denys Vlasenko <dvlasenk@...hat.com>,
	Johannes Berg <johannes.berg@...el.com>
Cc:	Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
	Intel Linux Wireless <ilw@...ux.intel.com>,
	Gregory Greenman <gregory.greenman@...el.com>,
	John Linville <linville@...driver.com>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iwlwifi: Deinline iwl_write8/write32/read32()

Hi Denys,

On Thu, 2015-09-24 at 16:58 +0200, Denys Vlasenko wrote:
> With this .config: http://busybox.net/~vda/kernel_config_ALLYES_Os,
> after deinlining these functions have sizes and callsite counts
> as follows:
> 
> iwl_write8: 315 bytes, 3 calls
> iwl_write32: 296 bytes, 90 calls
> iwl_read32: 278 bytes, 51 calls
> 
> Total size reduction is about 40 kbytes.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> CC: Johannes Berg <johannes.berg@...el.com>
> CC: Emmanuel Grumbach <emmanuel.grumbach@...el.com>
> CC: Intel Linux Wireless <ilw@...ux.intel.com>
> CC: Gregory Greenman <gregory.greenman@...el.com>
> CC: John Linville <linville@...driver.com>
> CC: linux-wireless@...r.kernel.org
> CC: linux-kernel@...r.kernel.org

Emmanuel already wrote and applied a patch like this.  Check here:
http://mid.gmane.org/1442869141-31637-4-git-send-email-luca@coelho.fi

Thanks for your patch anyway and for reporting this. :)

--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/