linux-kernel - Re: [PATCH 1/3] BTRFS: support NFSv2 export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151005143246.GW25218@ret.masoncoding.com>
Date:	Mon, 5 Oct 2015 10:32:46 -0400
From:	Chris Mason <clm@...com>
To:	Neil Brown <neilb@...e.de>
CC:	<dsterba@...e.cz>, Josef Bacik <jbacik@...com>,
	Jan Kara <jack@...e.cz>,
	Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>,
	<linux-fsdevel@...r.kernel.org>, <linux-nfs@...r.kernel.org>,
	<linux-nilfs@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-btrfs@...r.kernel.org>
Subject: Re: [PATCH 1/3] BTRFS: support NFSv2 export

On Thu, Sep 24, 2015 at 11:59:02AM +1000, Neil Brown wrote:
> David Sterba <dsterba@...e.cz> writes:
> 
> > On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote:
> >> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as
> >> that returned by encode_fh - it may be larger.
> >> 
> >> With NFSv2, the filehandle is fixed length, so it may appear longer
> >> than expected and be zero-padded.
> >> 
> >> So we must test that fh_len is at least some value, not exactly equal
> >> to it.
> >> 
> >> Signed-off-by: NeilBrown <neilb@...e.de>
> >
> > Acked-by: David Sterba <dsterba@...e.cz>
> 
> Thanks.  However I just checked mainline and this still hasn't been
> applied.
> Should I resend it to someone?  Who?


Sorry Neil, I thought you were pushing these after it was ack'd.  I'll
put it in my pull this week.

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/