[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20151005161332.GA11063@gmail.com>
Date: Mon, 5 Oct 2015 18:13:32 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Alexey Dobriyan <adobriyan@...il.com>
Cc: cmetcalf@...hip.com, Linux Kernel <linux-kernel@...r.kernel.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Thomas Gleixner <tglx@...utronix.de>,
"H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] string: Improve the generic strlcpy() implementation
* Ingo Molnar <mingo@...nel.org> wrote:
>
> * Alexey Dobriyan <adobriyan@...il.com> wrote:
>
> > I want to say two things:
> >
> > 1) strlcpy race
> >
> > > * In addition, the implementation is robust to the string changing out
> > > * from underneath it, unlike the current strlcpy() implementation.
> >
> > Canonical OpenBSD version does byte-by-byte copying,
> > this race is purely Linux invention.
> >
> > 2) strscpy() will copy garbage past NUL from source into destination.
> > It won't fault but still, who knows what lies after string.
>
> So I think your argument is nonsense on several levels:
Oh, you are right strscpy() - I mis-read your mail.
So the argument that is nonsensical here is mine!
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists