linux-kernel - Re: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc compiler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXr9JG3L0BUYrdhdyYehCZ46_bbzW6HjcNg6u+feypiOQ_gRw@mail.gmail.com>
Date:	Mon, 5 Oct 2015 14:59:42 -0700
From:	Petri Gynther <pgynther@...gle.com>
To:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Cc:	"acme@...hat.com" <acme@...hat.com>,
	"eranian@...gle.com" <eranian@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"aaro.koskinen@....fi" <aaro.koskinen@....fi>,
	"Vineet.Gupta1@...opsys.com" <Vineet.Gupta1@...opsys.com>,
	"acme@...nel.org" <acme@...nel.org>,
	"mingo@...hat.com" <mingo@...hat.com>
Subject: Re: [PATCH] perf tools: Fix build errors with mipsel-linux-uclibc compiler

On Sun, Oct 4, 2015 at 6:53 AM, Alexey Brodkin
<Alexey.Brodkin@...opsys.com> wrote:
> Hello Stephane, Armaldo,
>
> On Tue, 2015-09-22 at 00:06 +0300, Aaro Koskinen wrote:
>> Hi,
>>
>> On Mon, Sep 21, 2015 at 04:29:39PM +0000, Alexey Brodkin wrote:
>> > > Em Fri, Sep 04, 2015 at 04:01:54PM -0700, Petri Gynther escreveu:
>> > > > On Fri, Sep 4, 2015 at 3:48 PM, Arnaldo Carvalho de Melo
>> > > > <ac...@...nel.org> wrote:
>> > > > > Em Fri, Sep 04, 2015 at 03:45:03PM -0700, Petri Gynther escreveu:
>> > > > > > This commit breaks the perf tool MIPS build because MIPS doesn't have
>> > > > > > CONFIG_PERF_REGS=y in .config-detected:
>> > > > > >
>> > > > > > commit bcc84ec65ad1bd9f777a1fade6f8e5e0c5808fa5
>> > > > > > Author: Stephane Eranian <era...@...gle.com>
>> > > > > > Date:   Mon Aug 31 18:41:12 2015 +0200
>> > > > > >
>> > > > > >     perf record: Add ability to name registers to record
>> > > > >
>> > > > > There was a fix for another arch that came after this one.. here it is, already
>> > > > > upstream, can you take a look?
>> > > > >
>> > > > > commit af4aeadd8c04303c0aa2d112145c3627e2ebd026
>> > > > > Author: Stephane Eranian <era...@...gle.com>
>> > > > > Date:   Tue Sep 1 11:30:14 2015 +0200
>> > > > >
>> > > > >     perf tools: Fix link time error with sample_reg_masks on non x86
>> > > > >
>> > > > >     This patch makes perf compile on non x86 platforms by defining a weak
>> > > > >     symbol for sample_reg_masks[] in util/perf_regs.c.
>> > > > >
>> > > > >     The patch also moves the REG() and REG_END() macros into the
>> > > > >     util/per_regs.h header file. The macros are renamed to
>> > > > >     SMPL_REG/SMPL_REG_END to avoid clashes with other header files.
>> > > > >
>> > > > >
>> > > >
>> > > > I have the above commit in my tree (as I have the latest Linus' tree
>> > > > as of right now).
>> > > > The MIPS build is still broken as I reported.
>> > >
>> > > Stephane, can you please take a look?
>> >
>> > The same problem happens when building perf on ARC.
>> > I'm on 4.3-rc2 and that's what I see:
>> > ------------------->8-----------------
>> >   LINK     .../linux-4.3-rc2/tools/perf/perf
>> > .../linux-4.3-rc2/tools/perf/libperf.a(libperf-in.o): In function `parse_regs':
>> > .../linux-4.3-rc2/tools/perf/util/parse-regs-options.c:28: undefined reference to `sample_reg_masks'
>> > .../linux-4.3-rc2/tools/perf/util/parse-regs-options.c:45: undefined reference to `sample_reg_masks'
>> > .../linux-4.3-rc2/tools/perf/util/parse-regs-options.c:38: undefined reference to `sample_reg_masks'
>> > collect2: error: ld returned 1 exit status
>> > ------------------->8-----------------
>> >
>> > Any chance for this to be discussed any further?
>>
>> Also (with 4.3-rc2) on PA-RISC, PowerPC and SPARC the same errors are
>> seen. 4.2 builds fine.
>
> Any chance to take a look at this issue?
>
> It's already 4.3-rc3 so it would be nice to get some fix to try so there will be time
> to make sure that new fix doesn't break stuff for other arches.
>
> Regards,
> Alexey

I'd suggest to revert these two commits in Linus' tree:

commit af4aeadd8c04303c0aa2d112145c3627e2ebd026
Author: Stephane Eranian <eranian@...gle.com>
Date:   Tue Sep 1 11:30:14 2015 +0200

    perf tools: Fix link time error with sample_reg_masks on non x86

commit bcc84ec65ad1bd9f777a1fade6f8e5e0c5808fa5
Author: Stephane Eranian <eranian@...gle.com>
Date:   Mon Aug 31 18:41:12 2015 +0200

    perf record: Add ability to name registers to record

until this is figured out and tested for multiple architectures.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/