lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 06 Oct 2015 15:34:07 -0700 From: Vasu Dev <vasu.dev@...ux.intel.com> To: Jiri Slaby <jslaby@...e.cz> Cc: akpm@...ux-foundation.org, JBottomley@...n.com, kxie@...lsio.com, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, Robert Love <robert.w.love@...el.com>, fcoe-devel@...n-fcoe.org Subject: Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label On Tue, 2015-10-06 at 14:27 +0200, Jiri Slaby wrote: > There is a label pointing to the start of a while loop and a goto > nested only in the loop. The goto jumps to the label in some cases. > Replace the goto and the label by simple continue. > > Signed-off-by: Jiri Slaby <jslaby@...e.cz> > Cc: Robert Love <robert.w.love@...el.com> > Cc: fcoe-devel@...n-fcoe.org > --- > Sent on: > May 5 > > drivers/scsi/fcoe/fcoe.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c > index d3eb80c46bbe..d187ba9b361d 100644 > --- a/drivers/scsi/fcoe/fcoe.c > +++ b/drivers/scsi/fcoe/fcoe.c > @@ -1873,7 +1873,6 @@ static int fcoe_percpu_receive_thread(void *arg) > > set_user_nice(current, MIN_NICE); > > -retry: > while (!kthread_should_stop()) { > > spin_lock_bh(&p->fcoe_rx_list.lock); > @@ -1883,7 +1882,7 @@ retry: > set_current_state(TASK_INTERRUPTIBLE); > spin_unlock_bh(&p->fcoe_rx_list.lock); > schedule(); > - goto retry; > + continue; > } > > spin_unlock_bh(&p->fcoe_rx_list.lock); Acked-by: Vasu Dev <vasu.dev@...el.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists