lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151006231134.GV22011@ZenIV.linux.org.uk> Date: Wed, 7 Oct 2015 00:11:34 +0100 From: Al Viro <viro@...IV.linux.org.uk> To: Jacob Kiefer <jtk54@...nell.edu> Cc: Larry Finger <Larry.Finger@...inger.net>, Jes Sorensen <Jes.Sorensen@...hat.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Gujulan Elango, Hari Prasath (H.)" <hgujulan@...teon.com>, Roberta Dobrescu <roberta.dobrescu@...il.com>, "open list:STAGING - REALTEK RTL8723U WIRELESS DRIVER" <linux-wireless@...r.kernel.org>, "open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] staging: rtl8723au: Fix sparse errors in rtl8723a_cmd.c On Tue, Oct 06, 2015 at 12:32:28AM -0400, Jacob Kiefer wrote: > int rtl8723a_set_rssi_cmd(struct rtw_adapter *padapter, u8 *param) > { > - *((u32 *)param) = cpu_to_le32(*((u32 *)param)); > + __le32 leparam; > > - FillH2CCmd(padapter, RSSI_SETTING_EID, 3, param); > + leparam = cpu_to_le32(*((u32 *)param)); > + > + FillH2CCmd(padapter, RSSI_SETTING_EID, 3, (u8 *)&leparam); Why not fill the thing we are passing already with little-endian? There's only one caller, after all... > int rtl8723a_set_raid_cmd(struct rtw_adapter *padapter, u32 mask, u8 arg) > { > u8 buf[5]; > + __le32 lemask; > > memset(buf, 0, 5); > - mask = cpu_to_le32(mask); > - memcpy(buf, &mask, 4); > + lemask = cpu_to_le32(mask); > + memcpy(buf, &lemask, 4); > buf[4] = arg; > > FillH2CCmd(padapter, MACID_CONFIG_EID, 5, buf); Ugh... struct macid_config_eid {__le32 mask; u8 arg;} buf = { .mask = cpu_to_le32(mask), .arg = arg }; FillH2CCmd(padapter, MACID_CONFIG_EID, 5, &buf); Why bother with memcpy/memset/whatnot when all you are trying to do is to initialize a temporary structure? And no, it's not going to have any gaps... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists