lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 7 Oct 2015 01:24:38 +0200 From: Daniel Lezcano <daniel.lezcano@...aro.org> To: Felipe Balbi <balbi@...com>, Tony Lindgren <tony@...mide.com> Cc: Linux OMAP Mailing List <linux-omap@...r.kernel.org>, Linux ARM Kernel Mailing List <linux-arm-kernel@...ts.infradead.org>, tglx@...utronix.de, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 09/11] clocksource: add TI 32.768 Hz counter driver On 10/06/2015 07:02 PM, Felipe Balbi wrote: > Introduce a new clocksource driver for Texas > Instruments 32.768 Hz device which is available > on most OMAP-like devices. > > Signed-off-by: Felipe Balbi <balbi@...com> Hi Felipe, With the couple of nits below fixed, you can my: Acked-by: Daniel Lezcano <daniel.lezcano@...aro.org> [ ... ] > +#define OMAP2_32KSYNCNT_REV_OFF 0x0 > +#define OMAP2_32KSYNCNT_REV_SCHEME (0x3 << 30) > +#define OMAP2_32KSYNCNT_CR_OFF_LOW 0x10 > +#define OMAP2_32KSYNCNT_CR_OFF_HIGH 0x30 > + > +struct ti_32k { > + void __iomem *base; > + void __iomem *counter; > + struct clocksource cs; > +}; > +#define to_ti_32k(cs) (container_of((cs), struct ti_32k, cs)) Usually a static inline is used instead of a macro for that. > +static cycle_t ti_32k_read_cycles(struct clocksource *cs) > +{ > + struct ti_32k *ti = to_ti_32k(cs); format -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists