lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Oct 2015 08:23:28 +0100 From: Neil Armstrong <narmstrong@...libre.com> To: Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Guenter Roeck <linux@...ck-us.net>, vivien.didelot@...oirfairelinux.com, Andrew Lunn <andrew@...n.ch>, Fabian Frederick <fabf@...net.be>, Pavel Nakonechny <pavel.nakonechny@...tlab.ru>, Joe Perches <joe@...ches.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, nbd@...nwrt.org, sergei.shtylyov@...entembedded.com Subject: Re: [PATCH v2 3/5] net: dsa: complete dsa_switch_destroy On 10/03/2015 09:25 PM, Florian Fainelli wrote: > Le 03/10/2015 07:26, Neil Armstrong a écrit : >> When unbinding dsa, complete the dsa_switch_destroy to unregister the >> fixed link phy then cleanly unregister and destroy the net devices. >> >> Signed-off-by: Neil Armstrong <narmstrong@...libre.com> >> --- > > [snip] > >> + port_dn = cd->port_dn[port]; >> + if (of_phy_is_fixed_link(port_dn)) { >> + phydev = of_phy_find_device(port_dn); >> + if (phydev) { >> + int addr = phydev->addr; >> + phy_device_free(phydev); >> + of_node_put(port_dn); >> + fixed_phy_del(addr); > > fixed_phy_del() removes the fixed PHY from the platform fixed MDIO bus > list of PHYs, so we should be okay even with switch drivers which > register a link_update callback via fixed_phy_set_link_update(), but I > have not checked that. The sequence of call looks (phy_device_free then > fixed_phy_del) looks sane though. Actually I copied the exact sequence from the fixed link module, eventually this should be done in this module with a proper fixed_link_remove function. > > Eventually this logic might be better moved into net/dsa/slave.c such > that it is easy to see how it balances dsa_slave_phy_setup(). > > Reviewed-by: Florian Fainelli <f.fainelli@...il.com> > Thanks for the review, Neil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists