linux-kernel - Re: [PATCH] via-rhine: fix VLAN receive handling error in 4.2.x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151006073447.GA10346@electric-eye.fr.zoreil.com>
Date:	Tue, 6 Oct 2015 09:34:47 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Andrej Ota <andrej@....si>
Cc:	linux-kernel@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] via-rhine: fix VLAN receive handling error in 4.2.x

Andrej Ota <andrej@....si> :
> Fixes commit 810f19bcb862 ("via-rhine: add consistent memory barrier in
> vlan receive code.") which broke VLAN tag parsing on receive.
> 
> Because eth_type_trans() consumes ethernet header worth of bytes, a call
> to read TCI from packet using rhine_rx_vlan_tag() no longer works as it's
> reading from an invalid offset.
> 
> Tested to be working on PCEngines Alix board.
> 
> Fixes: 810f19bcb862 ("via-rhine: add consistent memory barrier in vlan receive code.")
> Signed-off-by: Andrej Ota <andrej@....si>

Minor nits:
- Ethernet driver patches should usually be sent to netdev@...r.kernel.org.
  Their state is thus tracked at
  http://patchwork.ozlabs.org/project/netdev/list/

- The more specific about the target branch, the better:
  [PATCH net 1/1] via-rhine: blah
  -> patch against davem's bugfixes branch
  [PATCH net-next 19/73] foo: more balh
  -> patch against davem's dev branch

- davem will take care of -stable propagation

-- 
Ueimor  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/