lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 6 Oct 2015 10:21:29 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	"Fu, Zhonghui" <zhonghui.fu@...ux.intel.com>
Cc:	Adrian Hunter <adrian.hunter@...el.com>,
	Neil Brown <neilb@...e.de>,
	Jaehoon Chung <jh80.chung@...sung.com>,
	Andreas Fenkart <afenkart@...il.com>,
	Joe Perches <joe@...ches.com>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] MMC/SDIO: enable SDIO device to suspend/resume asynchronously

On 21 September 2015 at 06:30, Fu, Zhonghui <zhonghui.fu@...ux.intel.com> wrote:
> Now, PM core supports asynchronous suspend/resume mode for devices
> during system suspend/resume, and the power state transition of one
> device may be completed in separate kernel thread. PM core ensures
> all power state transition timing dependency between devices. This
> patch enables SDIO card and function devices to suspend/resume
> asynchronously. This will take advantage of multicore and improve
> system suspend/resume speed.
>
> Signed-off-by: Zhonghui Fu <zhonghui.fu@...ux.intel.com>
> ---
> Changes in v2:
> - Amend commit message.
>
>  drivers/mmc/core/sdio.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
> index b91abed..6719b77 100644
> --- a/drivers/mmc/core/sdio.c
> +++ b/drivers/mmc/core/sdio.c
> @@ -1106,6 +1106,8 @@ int mmc_attach_sdio(struct mmc_host *host)
>                 pm_runtime_enable(&card->dev);
>         }
>
> +       device_enable_async_suspend(&card->dev);
> +
>         /*
>          * The number of functions on the card is encoded inside
>          * the ocr.
> @@ -1126,6 +1128,8 @@ int mmc_attach_sdio(struct mmc_host *host)
>                  */
>                 if (host->caps & MMC_CAP_POWER_OFF_CARD)
>                         pm_runtime_enable(&card->sdio_func[i]->dev);
> +
> +               device_enable_async_suspend(&card->sdio_func[i]->dev);
>         }
>
>         /*
> -- 1.7.1

I wonder how you guarantee that the mmc host device will be suspended
*after* the SDIO card device and the SDIO func device? Currently that
is controlled via device registration/probe order, without any device
hierarchy configured.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists